fix: ksvc annotation templating (#24)

* fix: chart template * test: validate service monitor template
linode · Jan 31, 2025 · 92ac07e · 92ac07e
1 parent 5534863
commit 92ac07e
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/quickstart-knative-service/templates/knative-svc.yaml b/quickstart-knative-service/templates/knative-svc.yaml
@@ -13,7 +13,7 @@ spec:
   template:
     metadata:
       {{- with .Values.annotations }}
-      annotations: {{- toYaml | nindent 8 }}
+      annotations: {{- toYaml . | nindent 8 }}
       {{- end }}
       {{- with .Values.podLabels }}
       labels:

diff --git a/quickstart-knative-service/values.yaml b/quickstart-knative-service/values.yaml
@@ -184,3 +184,5 @@ serviceMonitor:
   ## The service monitor is configured to use the private team Prometheus instance
   ## See: https://github.com/prometheus-operator/prometheus-operator/blob/main/Documentation/api.md#podmetricsendpoint
   endpoints: []
+    # - port: metrics
+    #   path: /metrics
diff --git a/tests/test-values.yaml b/tests/test-values.yaml
@@ -16,4 +16,16 @@ versionOne:
     repository: https://test/local
 
 serviceMonitor:
-  create: true
+  create: true
+  endpoints:
+    - port: metrics
+      path: /metrics
+
+annotations:
+  a1: 'a1-test'
+  a2: 'a2-test'
+
+
+podLabels:
+  l1: 'l1-test'
+  l2: 'l2-test'