Fix/ou cert mapping #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves aarnaud#7 switches to slog with standard logging levels of info,debug,warn,error. will make logging easier to include and more customizable. using standard slog package reduces third party dependencies too
Resolves aarnaud#28 Implements logic to consider both CN and OU as unique values for a certificate in the certificate map. This way we get metrics for certs that have the same CN but different Subject OUs - before, only CN was considered. This should still handle renewals correctly for the same cert, updating metrics in-place. That is why serial number or certificate fingerprint was not used as certs renewed in-place should retain their time series. I debated also adding Issuer information to uniquely identify these certs but did not think it was needed
standard for mise/asdf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aarnaud#29