[compat][server][client][test] Global RT DIV improvement (part 2): Ch… #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unking support for DIV message
This change mainly focuses on adding chunking support for DIV messages when they are produced to Kafka topics,
as the size of DIV message can be large. We leverage today's chunking mechanism for regular records and extend
it to support DIV with the following modifications:
1. All the DIV messages are of type {@link MessageType#CONTROL_MESSAGE_DIV} in its KafkaKey and their corresponding
KafkaMessageEnvelope uses Put as the payload.
2. Inside the Put payload, the actual message is stored in the putValue field and the schemaId can have the following cases:
- If the DIV message is non-chunked, the schemaId is set to GLOBAL_DIV_STATE.
- If the DIV message is chunk message, the schemaId is set to CHUNK.
- If the DIV message is a chunk manifest message, the schemaId is set to CHUNKED_VALUE_MANIFEST.
3. ChunkAssembler is adapted, on the receiver side, to buffer, assemble, and deserialize DIV messages (chunked/non-chunked).
lusong64
reviewed
Oct 23, 2024
| @@ -237,6 +239,8 @@ public abstract class StoreIngestionTask implements Runnable, Closeable { | |||
| * flushed to the metadata partition of the storage engine regularly in {@link #syncOffset(String, PartitionConsumptionState)} | |||
| */ | |||
| private final KafkaDataIntegrityValidator kafkaDataIntegrityValidator; | |||
| private ChunkAssembler divChunkAssembler; | |||
There was a problem hiding this comment.
Making it final? Or it would be difficult to construct a test?
lusong64
reviewed
Oct 23, 2024
| @@ -4336,4 +4384,9 @@ public boolean hasAllPartitionReportedCompleted() { | |||
| void setVersionRole(PartitionReplicaIngestionContext.VersionRole versionRole) { | |||
| this.versionRole = versionRole; | |||
| } | |||
|
|
|||
| // Only for testing purpose. | |||
There was a problem hiding this comment.
I understand everyone has their own habit. May I suggest to still make the divChunkAssembler final but creating a constructor that allows you to pass a mock divChunkAseembler? In that way, you don't have to have such a setter.
Either way needs one more method but the "setting a variable final" is better in execution for performance. Just a bit.
There was a problem hiding this comment.
Thanks for the review, @lusong64! SG. I will fix it.
lusong64
reviewed
Oct 23, 2024
lusong64
reviewed
Oct 23, 2024
| Put put = new Put(); | ||
| value.payloadUnion = put; | ||
| value.messageType = MessageType.PUT.getValue(); | ||
| PubSubTopic verstionTopic = pubSubTopicRepository.getTopic(Version.composeKafkaTopic("testStore", 1)); |
There was a problem hiding this comment.
oh, yes. Will fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…unking support for DIV message
This change mainly focuses on adding chunking support for DIV messages when they are produced to Kafka topics, as the size of DIV message can be large. We leverage today's chunking mechanism for regular records and extend it to support DIV with the following modifications:
How was this PR tested?
Does this PR introduce any user-facing changes?