Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-a-thon] [Not-For-Review] Client bindings and request flows for controller APIs createStore, getStoresInCluster and QueryJobStatus #1250

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mynameborat
Copy link
Contributor

@mynameborat mynameborat commented Oct 17, 2024

Summary, imperative, start upper case, don't end with a period

Client side bindings and GRPC changes to handle following controller APIs

  • createStore
  • getStoresInCluster
  • QueryJobStatus

Pending:

  • Wire in the appropriate GRPC port
  • Wire the config to enable the GRPC flow for controller route

Implementation choice is not cleaner as it requires to write lot of boiler plate for rest of the controller APIs. Working on another approach that would generalize all of it. Getting V1 of the approach for the Fix-a-thon

How was this PR tested?

Unit test

@mynameborat mynameborat marked this pull request as draft October 21, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant