Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[controller] refactor JobRoutes::populateJobStatus #1248

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[controller] refactor JobRoutes::populateJobStatus #1248

wants to merge 3 commits into from

Conversation

WhitneyDeng
Copy link
Collaborator

@WhitneyDeng WhitneyDeng commented Oct 17, 2024 •
edited
Loading

Summary, imperative, start upper case, don't end with a period

How was this PR tested?

  • Unit test
  • Untegration test
  • Manual testing
  • Other

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to explain your proposed changes and call out the behavior change.

Whitney Deng added 3 commits October 17, 2024 09:24
test PR
c05a1c7 
test commit: github token setup

create JobStatusRequest data model class to hold https request params for API request handler

rollback dummy PR changes

creating draft PR for refactoring JobStatus request. unfinished
Revert "test PR"
b106edb 
This reverts commit c05a1c7.
[controller] [refactor] [JobRoutes] refactor JobRoutes https request …
c82b043 
…to JobStatusRequest
@WhitneyDeng WhitneyDeng force-pushed the whdeng/fixathon-grpc-in-controller branch from 408514f to c82b043 Compare October 17, 2024 16:39
@WhitneyDeng WhitneyDeng changed the title Whdeng/fixathon grpc in controller [controller] refactor JobRoutes::populateJobStatus Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@WhitneyDeng