Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add createStoreRequest class and refactor CreateStore class to use it #1247

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add createStoreRequest class and refactor CreateStore class to use it #1247

wants to merge 4 commits into from

Conversation

akashvacher
Copy link

[controller] Refactor CreateStore::createStore API

  • Refactoring the APIs to ensure it can be called from both Spark-based HTTP server and gRPC server.

How was this PR tested?

WIP

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to explain your proposed changes and call out the behavior change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@akashvacher