Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[controller] Refactor StoresRoutes::getAllStores API #1246

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[controller] Refactor StoresRoutes::getAllStores API #1246

wants to merge 8 commits into from

Conversation

lucy2329
Copy link

@lucy2329 lucy2329 commented Oct 17, 2024 •
edited
Loading

[controller] Refactor StoresRoutes::getAllStores & StoresRoutes::getAllStoresStatuses API

  • Modify the getAllStores & getAllStoresStatuses API to support future gRPC migration.
  • Refactoring the APIs to ensure it can be called from both Spark-based HTTP server and gRPC server.

How was this PR tested?

  • Added Unit tests for getAllStoresStatuses and ListStoresRequestTest.java
  • WIP for getAllStores

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to explain your proposed changes and call out the behavior change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lucy2329