Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [controller][client][admin-tool] Add gRPC support in venice-controllers #1244

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

sushantmane
Copy link
Contributor

@sushantmane sushantmane commented Oct 17, 2024

Add gRPC support in controller

How was this PR tested?

CI

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to explain your proposed changes and call out the behavior change.

@sushantmane sushantmane changed the title Add controller handler service [EXPERIMENTAL] Add gRPC support in controller Oct 17, 2024
@sushantmane sushantmane marked this pull request as draft October 17, 2024 16:10
@sushantmane sushantmane changed the title [EXPERIMENTAL] Add gRPC support in controller [EXPERIMENTAL][Fixathon] Add gRPC support in controller Oct 17, 2024
@sushantmane sushantmane reopened this Oct 21, 2024
@sushantmane sushantmane force-pushed the fixathon-grpc-in-controller branch 2 times, most recently from 47901dc to f4ec577 Compare October 22, 2024 02:59
- Add controller handler service
- Add gRPC server
- Get Bharat's changes
- Add create store api
- Fix error handling and fix transports used in ControllerClient to be able to run tests with gRpc

Add config to turn on and off gRPC server

Add secure gRPC server
@sushantmane sushantmane changed the title [EXPERIMENTAL][Fixathon] Add gRPC support in controller [WIP] Add gRPC support in venice-controllers Oct 25, 2024
@sushantmane sushantmane changed the title [WIP] Add gRPC support in venice-controllers [WIP] [controller][client][admin-tool] Add gRPC support in venice-controllers Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants