-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] [controller][client][admin-tool] Add gRPC support in venice-controllers #1244
Draft
sushantmane
wants to merge
11
commits into
linkedin:main
Choose a base branch
from
sushantmane:fixathon-grpc-in-controller
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[WIP] [controller][client][admin-tool] Add gRPC support in venice-controllers #1244
sushantmane
wants to merge
11
commits into
linkedin:main
from
sushantmane:fixathon-grpc-in-controller
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sushantmane
force-pushed
the
fixathon-grpc-in-controller
branch
from
October 17, 2024 07:07
8541e7e
to
2ef55a7
Compare
sushantmane
changed the title
Add controller handler service
[EXPERIMENTAL] Add gRPC support in controller
Oct 17, 2024
sushantmane
changed the title
[EXPERIMENTAL] Add gRPC support in controller
[EXPERIMENTAL][Fixathon] Add gRPC support in controller
Oct 17, 2024
sushantmane
force-pushed
the
fixathon-grpc-in-controller
branch
2 times, most recently
from
October 22, 2024 02:59
47901dc
to
f4ec577
Compare
- Add controller handler service - Add gRPC server - Get Bharat's changes - Add create store api - Fix error handling and fix transports used in ControllerClient to be able to run tests with gRpc Add config to turn on and off gRPC server Add secure gRPC server
…ataRoutes, ClusterRoutes, and VersionRoute
sushantmane
force-pushed
the
fixathon-grpc-in-controller
branch
from
October 24, 2024 02:42
24e2568
to
9f86a7b
Compare
sushantmane
force-pushed
the
fixathon-grpc-in-controller
branch
from
October 25, 2024 03:48
1caa5ab
to
49f495b
Compare
sushantmane
changed the title
[EXPERIMENTAL][Fixathon] Add gRPC support in controller
[WIP] Add gRPC support in venice-controllers
Oct 25, 2024
sushantmane
changed the title
[WIP] Add gRPC support in venice-controllers
[WIP] [controller][client][admin-tool] Add gRPC support in venice-controllers
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add gRPC support in controller
How was this PR tested?
CI
Does this PR introduce any user-facing changes?