Disable dark traffic dispatching during dark warmup #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bohhyang
approved these changes
Oct 25, 2024
Comment on lines
+124
to
+128
| for (ZooKeeperAnnouncer announcer : _announcers) { | ||
| if (announcer.isWarmingUp()) { | ||
| return false; | ||
| } | ||
| } |
There was a problem hiding this comment.
Just a nit
Suggested change
| for (ZooKeeperAnnouncer announcer : _announcers) { | |
| if (announcer.isWarmingUp()) { | |
| return false; | |
| } | |
| } | |
| if (_announcers.stream().anyMatch(ZooKeeperAnnouncer::isWarmingUp)) | |
| { | |
| return false; | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sending dark traffic during dark warmup is risky since it can result in the calls being sent back to the same hosts, resulting in a cycle.
Changes:
ZookeeperAnnouncerin dark cluster utils to ensure that no dark requests are sent while any of the announcers is in warmup mode (and the app is receiving some dark traffic).Testing
Added UT.