Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore the old constructor to avoid incompatible issue #1029

Merged
merged 10 commits into from
Oct 18, 2024
Merged

Restore the old constructor to avoid incompatible issue #1029

merged 10 commits into from
Oct 18, 2024

Conversation

brycezhongqing
Copy link
Collaborator

As title

zackthehuman
zackthehuman approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@zackthehuman zackthehuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this back!

@zackthehuman
Copy link
Contributor

This should fix the regression from #1027 with the constructors.

bohhyang
bohhyang reviewed Oct 17, 2024
View reviewed changes
gradle.properties Outdated Show resolved Hide resolved
@brycezhongqing brycezhongqing mentioned this pull request Oct 18, 2024
Open
@brycezhongqing brycezhongqing merged commit 5f9ef25 into master Oct 18, 2024
1 of 2 checks passed
@brycezhongqing brycezhongqing deleted the zhonchen/restore_legacy_constructor branch October 18, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zackthehuman zackthehuman zackthehuman approved these changes

@bohhyang bohhyang bohhyang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brycezhongqing @zackthehuman @bohhyang