Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make buildTopicName(String, String, String) public #318

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make buildTopicName(String, String, String) public #318

wants to merge 2 commits into from

Conversation

derekpham
Copy link
Contributor

Details

This is useful for the backfill tool when user might provide an entity type and aspect name.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

jsdonn
jsdonn previously approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@jsdonn jsdonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsdonn jsdonn dismissed their stale review November 16, 2023 20:23

please check that there is a unit test for this now exposed method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsdonn jsdonn jsdonn left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derekpham @jsdonn