Add option in SchemaBuilder to ignore user defined json properties during codegen. #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
li-ukumar
requested review from
radai-rosenblatt,
dg-builder and
xiaoyu-yang-gh
li-ukumar
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #542 +/- ##
============================================
+ Coverage 46.15% 46.17% +0.02%
- Complexity 4534 4545 +11
============================================
Files 407 407
Lines 28393 28447 +54
Branches 4633 4634 +1
============================================
+ Hits 13104 13135 +31
- Misses 13721 13748 +27
+ Partials 1568 1564 -4 ☔ View full report in Codecov by Sentry. |
Comment on lines
247
to
251
| List<String> jsonPropsToIgnoreInCompare = new ArrayList<>(); | ||
| if(options.has(jsonPropsToIgnoreInCompareOpt)) { | ||
| jsonPropsToIgnoreInCompare = options.valuesOf(jsonPropsToIgnoreInCompareOpt); | ||
| } | ||
|
|
There was a problem hiding this comment.
nit: change to:
List jsonPropsToIgnoreInCompare = options.has(jsonPropsToIgnoreInCompareOpt) ? options.valuesOf(jsonPropsToIgnoreInCompareOpt) : Collections.emptyList();
| @@ -238,6 +244,11 @@ public static void main(String[] args) throws Exception { | |||
| skipCodegenIfSchemaOnClasspath = Boolean.TRUE.equals(Boolean.parseBoolean(value)); | |||
| } | |||
|
|
|||
| List<String> jsonPropsToIgnoreInCompare = new ArrayList<>(); | |||
There was a problem hiding this comment.
I saw eventually you have this as a HashSet. why not have it as a Set at the beginning?
xiaoyu-yang-gh
approved these changes
Jan 19, 2024
|
I don't advise doing this. If folks rely on reading these properties from runtime schema they may get nasty surprises. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adding option to ignore json properties in SchemaBuilder
Why
During avro codegen, the if the generator detects conflicting defintions of a schema, where the filesystem definition is different from the one in classpath, it throws.
Relaxing this check by allowing the user to specify json properties to be ignored during this check.
It is useful if the duplicate schema is "almost" same but has certain properties which may store metadata for another flow.
Test
Added Sanity Unit test
build