Set TargetFormat to TrackTransformationObject when initiating the sta…

…ts. If the format is not set here initially then it is never available in cases where we fail to create a corresponding TrackTranscoder. (#262)
linkedin · Aug 16, 2023 · f894a68 · f894a68
1 parent c3c0c4b
commit f894a68
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/litr/src/main/java/com/linkedin/android/litr/TransformationJob.java b/litr/src/main/java/com/linkedin/android/litr/TransformationJob.java
@@ -132,8 +132,10 @@ protected void error(@Nullable Throwable cause) {
     @VisibleForTesting
     void initStatsCollector() {
         // TODO modify TrackTransformationInfo to report muxing/demuxing and different media sources/targets
-        for (TrackTransform trackTransform : trackTransforms) {
+        for (int track = 0; track < trackTransforms.size(); track++) {
+            TrackTransform trackTransform = trackTransforms.get(track);
             statsCollector.addSourceTrack(trackTransform.getMediaSource().getTrackFormat(trackTransform.getSourceTrack()));
+            statsCollector.setTargetFormat(track, trackTransform.getTargetFormat());
         }
     }
 

diff --git a/litr/src/test/java/com/linkedin/android/litr/TransformationJobShould.java b/litr/src/test/java/com/linkedin/android/litr/TransformationJobShould.java
@@ -210,8 +210,10 @@ public void transformWhenNoErrors() throws Exception {
         transformationJob.transform();
 
         verify(marshallingTransformationListener).onCompleted(eq(JOB_ID), ArgumentMatchers.<TrackTransformationInfo>anyList());
+        verify(statsCollector).setTargetFormat(0, targetVideoFormat);
         verify(statsCollector).addSourceTrack(sourceVideoFormat);
         verify(statsCollector).addSourceTrack(sourceAudioFormat);
+        verify(statsCollector).setTargetFormat(1, targetAudioFormat);
     }
 
     @Test(expected = InsufficientDiskSpaceException.class)