Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE] chore: update to v0.3.1 #29

Merged
merged 6 commits into from
Jul 29, 2024
Merged

[RELEASE] chore: update to v0.3.1 #29

merged 6 commits into from
Jul 29, 2024

Conversation

simbleau
Copy link
Member

@simbleau simbleau commented Jul 29, 2024

Fix the changelog format of previous releases.

Release version 0.3.1.

@simbleau
Copy link
Member Author

@nicoburns for awareness, as the release was requested by them.

@simbleau simbleau added this pull request to the merge queue Jul 29, 2024
@DJMcNab DJMcNab removed this pull request from the merge queue due to a manual request Jul 29, 2024
@DJMcNab
Copy link
Member

DJMcNab commented Jul 29, 2024

I've backed this out because of the PR description - making commits which mention people has occasionally backfired, because GitHub likes pinging that user when people make forks/do merges incorrectly, etc.

I've had that a few times in Bevy, and so want to avoid that here.

(I also don't think that we should include the full changelog in the PR description anyway, because those changes aren't actually in this PR)

I'd suggest changing the description to just something like:

Fix the changelog format of previous releases.

Release version 0.3.1.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably also add the equivalent paragraph to https://github.com/linebender/vello/blob/main/CHANGELOG.md#changelog here (i.e. the latest published Vello SVG release is ...)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@waywardmonkeys
Copy link
Contributor

And please fix the changelog in a separate PR from doing the release.

@simbleau
Copy link
Member Author

simbleau commented Jul 29, 2024

I've backed this out because of the PR description - making commits which mention people has occasionally backfired, because GitHub likes pinging that user when people make forks/do merges incorrectly, etc.

I've had that a few times in Bevy, and so want to avoid that here.

(I also don't think that we should include the full changelog in the PR description anyway, because those changes aren't actually in this PR)

I'd suggest changing the description to just something like:

Fix the changelog format of previous releases.

Release version 0.3.1.

Yeah, my bad. I didn't realize the merge queue takes the description and uses it as a commit message. I'll take a mental note of that in the future.

@simbleau
Copy link
Member Author

And please fix the changelog in a separate PR from doing the release.

And please fix the changelog in a separate PR from doing the release.

Done, that's now #30

@simbleau simbleau requested a review from DJMcNab July 29, 2024 14:24
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@DJMcNab
Copy link
Member

DJMcNab commented Jul 29, 2024

Not approving until #30 lands and is merged with this.

Co-authored-by: Daniel McNab <[email protected]>
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@simbleau simbleau enabled auto-merge July 29, 2024 15:20
@simbleau simbleau added this pull request to the merge queue Jul 29, 2024
Merged via the queue into main with commit 3cc2bf6 Jul 29, 2024
12 checks passed
@simbleau simbleau deleted the v0.3.1 branch July 29, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants