-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial code from Vello. #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had time to only quickly skim a few files, but I already have a few comments inline.
The unifying idea of my complaints is that I think we should stick more closely to established Linebender culture. Not to say that these things are unchangeable forever, but at the very least this initial seed is the wrong place to start changing such things.
Co-authored-by: Kaur Kuut <[email protected]>
They were good comments, thanks for the initial review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's another pass. Might have missed something, because looks like the fork wasn't based on the freshest main
of the Vello repo. Although I guess we don't necessarily need all of that, like vello#435?
Co-authored-by: Kaur Kuut <[email protected]>
Co-authored-by: Kaur Kuut <[email protected]>
Co-authored-by: Kaur Kuut <[email protected]>
Co-authored-by: Kaur Kuut <[email protected]>
Co-authored-by: Kaur Kuut <[email protected]>
Co-authored-by: Kaur Kuut <[email protected]>
Co-authored-by: Kaur Kuut <[email protected]>
Co-authored-by: Kaur Kuut <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we've reached a state where this can be merged. 🎉
Before merging, I'll note two things:
- The PR title should be changed (I'll just do it myself in a second)
- Use the Squash Merge option to do the merge, as that is the Linebender way
Thanks for putting in the effort to get this landed!
This PR initializes the repo to a basic state.