Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

self.value.push('.') calculator . fix __display #2388

Closed
wants to merge 1 commit into from

Conversation

YoungHaKim7
Copy link

@YoungHaKim7 YoungHaKim7 commented Aug 5, 2023

ex )
36. 3

If you press 36.3, 36 is followed by 3. I think this is better.

89            '.' => {
90                if !self.in_num {
91                    self.value.push('.');
92                    self.in_num = true;
93                }

@xStrom
Copy link
Member

xStrom commented Aug 5, 2023

I can not reproduce the bug you are describing.

Also, this patch breaks the following sequence: 2 x . 5 = by giving the answer 5 instead of 1.

Do you still get 1 as the answer to this test?

@xStrom xStrom added the S-waiting-on-author waits for changes from the submitter label Aug 5, 2023
@YoungHaKim7
Copy link
Author

66                 if self.in_num {
                    self.value = "0".to_string();
                    self.in_num = true;
                }

It's my mistake. I'm sorry.
I skipped an exclamation point on the 66th line. I'm sorry. I'll close it.

@YoungHaKim7 YoungHaKim7 closed this Aug 5, 2023
@xStrom xStrom removed the S-waiting-on-author waits for changes from the submitter label Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants