fix: channel update bug (#112)

* fix: image config as optional on updating channel * fix: same channel name between projects
line · Dec 19, 2023 · b2dfc1a · b2dfc1a
1 parent f8908e0
commit b2dfc1a
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/apps/api/src/domains/channel/channel/channel.mysql.service.ts b/apps/api/src/domains/channel/channel/channel.mysql.service.ts
@@ -100,7 +100,11 @@ export class ChannelMySQLService {
 
     if (
       await this.repository.findOne({
-        where: { name, id: Not(channelId) },
+        where: {
+          name,
+          id: Not(channelId),
+          project: { id: channel.project.id },
+        },
         select: ['id'],
       })
     ) {

diff --git a/apps/api/src/domains/channel/channel/dtos/requests/update-channel-request.dto.ts b/apps/api/src/domains/channel/channel/dtos/requests/update-channel-request.dto.ts
@@ -14,7 +14,13 @@
  * under the License.
  */
 import { ApiProperty } from '@nestjs/swagger';
-import { IsObject, IsString, MaxLength, MinLength } from 'class-validator';
+import {
+  IsObject,
+  IsOptional,
+  IsString,
+  MaxLength,
+  MinLength,
+} from 'class-validator';
 
 import { IsNullable } from '@/domains/user/decorators';
 import { ImageConfigRequestDto } from './image-config-request.dto';
@@ -32,7 +38,8 @@ export class UpdateChannelRequestDto {
   @MaxLength(50)
   description: string | null;
 
-  @ApiProperty({ nullable: true, type: ImageConfigRequestDto })
+  @ApiProperty({ required: false, nullable: true, type: ImageConfigRequestDto })
+  @IsOptional()
   @IsNullable()
   @IsObject()
   imageConfig: ImageConfigRequestDto | null;