[Draft] ✨ Preview generation as a separate node instance #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shepilov
force-pushed
the
scale_preview_generation
branch
from
1f7bbca
to
386bfaa
Compare
shepilov
changed the title
ericlinagora
requested changes
Nov 7, 2024
Comment on lines
+113
to
+141
| onlyoffice-rabbitmq: | ||
| image: rabbitmq:management | ||
| hostname: onlyoffice-rabbitmq | ||
| container_name: rabbitmq | ||
| environment: | ||
| - RABBITMQ_DEFAULT_USER=guest | ||
| - RABBITMQ_DEFAULT_PASS=guest | ||
| ports: | ||
| - "5672:5672" | ||
| - "15672:15672" | ||
| volumes: | ||
| - ./.docker-conf/rabbitmq/data/:/var/lib/rabbitmq/ | ||
| - ./.docker-conf/rabbitmq/log/:/var/log/rabbitmq | ||
| networks: | ||
| - tdrive_network | ||
|
|
||
| onlyoffice-postgresql: | ||
| image: postgres:13 | ||
| hostname: onlyoffice-postgresql | ||
| environment: | ||
| - POSTGRES_DB=onlyoffice | ||
| - POSTGRES_USER=onlyoffice | ||
| - POSTGRES_PASSWORD=onlyoffice | ||
| ports: | ||
| - 5432:5432 | ||
| volumes: | ||
| - ./onlyoffice_postgres_data:/var/lib/postgresql/data | ||
| networks: | ||
| - tdrive_network |
There was a problem hiding this comment.
This shouldn't be required, they are builtin to only office, we should only nneed them separate for persistence when onlyoffice itself restarts/redeploys.
| @@ -0,0 +1,166 @@ | |||
| version: "3.4" | |||
There was a problem hiding this comment.
This compose is not properly waiting for service availability, this cause intermittent errors before (a lot more than we have now). See example at:
| @@ -18,6 +18,7 @@ | |||
| }, | |||
| "webserver": { | |||
| "host": "TWAKE_DRIVE_HOST", | |||
| "port": "TWAKE_DRIVE_PORT", | |||
There was a problem hiding this comment.
did you forget to git add ..../services/webserver/index.ts ? I can't find where this is read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.