Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ci/switch backend tests to postgres #684

Closed
wants to merge 2 commits into from
Closed

Ci/switch backend tests to postgres #684

wants to merge 2 commits into from

Conversation

ericlinagora
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added the Signed-off-by statement at the end of my commit message.

@ericlinagora ericlinagora force-pushed the ci/switch_backend_tests_to_postgres branch 2 times, most recently from 6579ccf to 0ca308a Compare October 9, 2024 18:50
@ericlinagora ericlinagora marked this pull request as ready for review October 9, 2024 19:17
@ericlinagora ericlinagora force-pushed the ci/switch_backend_tests_to_postgres branch from 0ca308a to 4437705 Compare October 9, 2024 19:59
@ericlinagora ericlinagora marked this pull request as draft October 10, 2024 09:56
shepilov
shepilov requested changes Oct 10, 2024
View reviewed changes
Copy link
Member

@shepilov shepilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just drop it, postgres is tested with opensearch

@ericlinagora ericlinagora deleted the ci/switch_backend_tests_to_postgres branch October 10, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shepilov shepilov shepilov requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericlinagora @shepilov