🕹 Manage root users #146
Merged
🕹 Manage root users #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chibenwa
reviewed
Jul 7, 2023
| @@ -175,6 +186,13 @@ export class DocumentsController { | |||
| ) | |||
| : [], | |||
| }; | |||
|
|
|||
| if(id == "root" && companyUserRole < 1) { | |||
There was a problem hiding this comment.
What does 1 mean?
(Magic constant spotted).
I recommend to extract this as a global variable and give it a name.
Comment on lines
110
to
112
| /* useEffect(() => { | ||
| props.onChangePassword(usePassword ? password : ''); | ||
| }, [usePassword, password]); */ |
chibenwa
reviewed
Jul 19, 2023
| @@ -187,7 +189,7 @@ export class DocumentsController { | |||
| : [], | |||
| }; | |||
|
|
|||
| if(id == "root" && companyUserRole < 1) { | |||
| if (id == "root" && companyUserRole < 1) { | |||
There was a problem hiding this comment.
What is the meaning of 1 here?
That's the magic constant syndrom. I would recommand to:
-
- Strong type. It looks like some kind of permissions is encoded as an
int. This could be made explicit with a type, that could furthermore encapsulate and centralize right checking logic, that then could (must?) be unit tested?
- Strong type. It looks like some kind of permissions is encoded as an
-
- Extract constants to give them a name. Favor
enums if supported in typescript.
- Extract constants to give them a name. Favor
| { id: update.company_id }, | ||
| { id: update.user_id }, | ||
| ); | ||
| if (companyUser) { |
There was a problem hiding this comment.
What happens if the guy is not a company user?
We likely should return an HTTP error for this, no? 406 not acceptable ?
Coverage Report
Click to view remaining coverage report
|
chibenwa
reviewed
Aug 22, 2023
| @@ -189,7 +189,7 @@ export class DocumentsController { | |||
| : [], | |||
| }; | |||
|
|
|||
| if (id == "root" && companyUserRole < 1) { | |||
| if (id == "root" && companyUserRole == 1) { | |||
There was a problem hiding this comment.
Can we create constants for each value user role?
Or even better use an enum: https://www.typescriptlang.org/docs/handbook/enums.html ?
There was a problem hiding this comment.
The snippet above is outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.