[WIP] Split ContactsCollection mailet #1308
Draft
+279
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chibenwa
reviewed
Nov 15, 2024
Comment on lines
+120
to
+121
| NO_REGISTRATION_KEYS) | ||
| ).collectList() |
There was a problem hiding this comment.
Suggested change
| NO_REGISTRATION_KEYS) | |
| ).collectList() | |
| NO_REGISTRATION_KEYS)) | |
| .collectList() |
chibenwa
reviewed
Nov 15, 2024
| .map(AttributeValue::value) | ||
| .map(Throwing.function(this::parseUserContacts)) | ||
| .flatMap(Throwing.function(this::dispatchContactsAddedEvent)) | ||
| .onErrorMap(e -> new MailetException("Failed to index contacts", new Exception(e))) |
There was a problem hiding this comment.
We are not on a critical feature, so we should WARN on error and avoid propagating the exception
chibenwa
reviewed
Nov 15, 2024
| @@ -0,0 +1,128 @@ | |||
| package com.linagora.tmail.mailets; | |||
There was a problem hiding this comment.
Shall we remove the old class?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1257
TODO
com.fasterxml.jackson.databind.exc.InvalidDefinitionException: Cannot construct instance of org.apache.james.transport.mailets.ContactExtractor$ExtractedContactsContactsCollectionleftovers (code, doc, tests, etc...)