Feature: Take photos and videos and record voice memos #961
Conversation
|
What is |
|
idont have mac for ios demo |
added adr |
|
what happen if you reject permission? |
lib/presentation/widget/record_audio/record_audio_viewmodel.dart
Outdated
Show resolved
Hide resolved
lib/presentation/widget/record_audio/record_audio_viewmodel.dart
Outdated
Show resolved
Hide resolved
lib/presentation/widget/record_audio/record_audio_viewmodel.dart
Outdated
Show resolved
Hide resolved
lib/presentation/widget/record_audio/record_audio_viewmodel.dart
Outdated
Show resolved
Hide resolved
lib/presentation/widget/record_audio/record_audio_viewmodel.dart
Outdated
Show resolved
Hide resolved
lib/presentation/widget/record_audio/record_audio_viewmodel.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
a lot of format make the review hard
|
please use |
display a toast and return to the previous screen |
lib/presentation/widget/shared_space_document/shared_space_document_viewmodel.dart
Show resolved
Hide resolved
lib/presentation/widget/shared_space_document/shared_space_document_viewmodel.dart
Show resolved
Hide resolved
lib/l10n/intl_messages.arb
Outdated
| "placeholders_order": [], | ||
| "placeholders": {} | ||
| }, | ||
| "give_access_in_settings": "Please give linshare access in the settings to continue", |
There was a problem hiding this comment.
And we should more detail on what permission and why we need it? This is a chance for clearer information to user.
| child: Text(AppLocalizations.of(context).cancel), | ||
| ), | ||
| TextButton( | ||
| onPressed: () => Navigator.of(context).pop(true), |
There was a problem hiding this comment.
try to handle the case: user cancel here, and somewhere after capturing video/audio call, we should clear the temporary file too. Please demo this case also
There was a problem hiding this comment.
Handled
cache_cleanup.mp4
| "placeholders_order": [], | ||
| "placeholders": {} | ||
| }, | ||
| "exit": "exit", |
There was a problem hiding this comment.
@KhaledNjim please dont forget it
There was a problem hiding this comment.
What do i discard ?
There was a problem hiding this comment.
I mean, change it to Discard or Exit.
KhaledNjim
force-pushed
the
camera_and_mic_support
branch
from
d9c6e8b
to
7ef1155
Compare
|
The storage is not taken care well. When user refuse to upload it, storage still be increase Screen_Recording_20241115_123258_LinShare.mp4 |
User story
Demo (android 34)
34.webm
Demo (android 33)
Screen_recording_20240603_211703.webm
Demo (android 28)
28.webm
Demo (android 27)
27.webm
Camera permission demo
permission_cam.webm
Audio recording permission demo
recper.webm
Open settings when permission is permantly denied
openSettings.webm