Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LA-1296 changed key value for oidc-Jwt #956

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

KhaledNjim
Copy link
Collaborator

Description

gitlab issue

when trying to login using sso with oidc-jwt the authentication fails

Root cause

The oidc_parser is comparing to a wrong value for oidc token type JWT instead of Oidc-Jwt so it's always defaulting to using Oidc-opaque

Solution

Changed to the right value

@KhaledNjim KhaledNjim requested a review from hoangdat May 17, 2024 01:55
@KhaledNjim KhaledNjim requested a review from hoangdat June 3, 2024 07:28
@hoangdat hoangdat merged commit 5e6d2eb into master Jun 3, 2024
4 checks passed
@hoangdat hoangdat deleted the bugFix_cannot_login_with_sso branch June 3, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants