Add compatibility with league/oauth2-server 9 #31
+171
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated unit tests so they succeed after |
These properties are also declared in the base class(es) so don't need to be declared again. Futhermore on oauth2-server 9 these properties are typed which leads to incompatible declaration errors.
`AccessTokenEntityInterface::getScopes()` is not needed as the interface extends `TokenInterface` which declares the identical method (including identical PHPDoc). The method should be dropped as well to ease compatibility with `league/oauth2-server` 8 & 9 as the method of the base interface adds the `array` return type, which is harder to add to `AccessTokenEntityInterface` while maintaining compatibility with `league/oauth2-server` 8 (as the `getScopes()` implementation in `AccessTokenTrait` isn't compatible because that still doesn't have a return type). While when dropping the method declaration here makes sure that the interface is declared in `league/oauth2-server` and the actual implementation of the interface method is also in `league/oauth2-server` which means it's always compatible.
RobertMe
force-pushed
the
server-9-compat
branch
from
d3a1192 to
edbfc7b
Compare
…erting afterwards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add compatibility with league/oauth2-server 9 while maintaining support with version 8 as well.
Tested by using this branch both with league/oauth2-server 8 & 9. And for both versions going through the steps of oauthdebugger.com including decoding the id_token and requesting the user info endpoint. Which was successful without making any further changes to the code of my project.