This repository has been archived by the owner on Feb 27, 2021. It is now read-only.
Fix args as str #25
Open
Fix args as str #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update AUTHORS.txt
…ster Added CompletedTaskAdmin
…er use with popping from the empty queue.
…ster Async execution of tasks and refactoring.
Changes an implicit import of models_completed in the admin.py file to be an absolute explicit import. This makes it work in python3.
Fixes for Python 3
…ster get_query_set / get_queryset
…arn-if-cant-reach-db Catch Database Outage Errors
Even though a PR was made to modify the fields for MySQL's utf8mb4 charset (max key length 191), the initial migration was still trying to create it at 255. Perhaps modifying the initial migration isn't the right way to fix this, but I'm not sure what else to do.
remove "makemigrations" step from docs
Tested with Django 2.1
Modify initial migration to use acceptable max_lengths on indexed fields for MySQL utf8mb4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my case (Django 1.11, running on Windows, Python 2.7) the arguments to a Django commands are not processed as integers or floats. It means that the
durationandsleepargument are alwaysstrand are mostly ignored by Python. Since it doesn't seem to be the "normal" behavior and I couldn't find a resource that explained the reason for this strange side-effect, I added a conditional cast which might be somewhat ugly. Lacking any better information, I would say this works for me and shouldn't break anything for others... hopefully.Thanks for the great app!