Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deprecation): remove deprecated spaceless filter #1609

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

JohJohan
Copy link

@JohJohan JohJohan commented Sep 4, 2024

Q A
Branch? 2.x and should also merge to 3.x
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Fixed tickets -
License MIT
Doc -

This will remove the deprecated spaceless filter from twig see: twigphp/Twig#4236

@coveralls
Copy link

Coverage Status

coverage: 81.746%. remained the same
when pulling 5e8a117 on JohJohan:deprecated-spaceless
into f3b6742 on liip:2.x.

Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@dbu dbu merged commit 8a2c9fc into liip:2.x Sep 4, 2024
29 of 30 checks passed
@JohJohan JohJohan deleted the deprecated-spaceless branch September 4, 2024 11:59
@JohJohan
Copy link
Author

JohJohan commented Sep 4, 2024

@dbu will you also merge it to the 3.x branch? And create tags?

@dbu
Copy link
Member

dbu commented Sep 4, 2024

here you go https://github.com/liip/LiipImagineBundle/releases/tag/2.13.2

i will merge to the 3.x branch too. note that 3.x is likely to massively change before release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants