Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 to 3 #1597

Merged
merged 4 commits into from
Jul 3, 2024
Merged

2 to 3 #1597

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,17 @@ for a given releases. Unreleased, upcoming changes will be updated here periodic

# 2.x

## [2.13.1](https://github.com/liip/LiipImagineBundle/tree/2.13.1)

- Fix Json Manifest handling when manifest file does not exist yet ([AirBair](https://github.com/liip/LiipImagineBundle/pull/1600))

## [2.13.0](https://github.com/liip/LiipImagineBundle/tree/2.13.0)

- Support JsonManifestVersionStrategy that was added in Symfony 6.
- Support JsonManifestVersionStrategy that was added in Symfony 6 ([wouterSkepp](https://github.com/liip/LiipImagineBundle/pull/1529)).

## [2.12.3](https://github.com/liip/LiipImagineBundle/tree/2.12.3)

- Add alias for `Imagine\Image\ImagineInterface` to help autowiring.
- Add alias for `Imagine\Image\ImagineInterface` to help autowiring ([dbu](https://github.com/liip/LiipImagineBundle/pull/1583)).

## [2.12.2](https://github.com/liip/LiipImagineBundle/tree/2.12.2)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,11 @@ public function process(ContainerBuilder $container): void
$runtimeDefinition->setArgument(1, $version);

if (is_a($versionStrategyDefinition->getClass(), JsonManifestVersionStrategy::class, true)) {
if (!file_exists($version)) {
$this->log($container, 'The manifest file at "'.$version.'" does not yet exist');

return;
}
$jsonManifestString = file_get_contents($version);

if (!\is_string($jsonManifestString)) {
Expand Down
Loading