Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement delete row and column in UI #144

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Implement delete row and column in UI #144

wants to merge 8 commits into from

Conversation

Yousif-FJ
Copy link
Contributor

This also removes the column and row index attributes which are used in the selection; Replaced by using the DOM approach.

@Yousif-FJ Yousif-FJ linked an issue May 2, 2024 that may be closed by this pull request
Implement delete row and column in UI #73
Open
@Fluglow
Copy link
Contributor

Fluglow commented May 3, 2024

Is there a reason to use the concept of CellGroup in the event protocol? It seems that there's no common code, just checking the type each time. Maybe it could be split into delete column/row payloads?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement delete row and column in UI
2 participants
@Yousif-FJ @Fluglow