UI cell style #118
Open
UI cell style #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main.ts # src/main.types.ts
# Conflicts: # src/main.ts
# Conflicts: # index.js # src/core/event/events.types.ts # src/core/structure/cell/cell.ts # src/core/structure/sheet.ts # src/main.ts # src/main.types.ts # src/ui/render.ts # src/utils/helpers.ts
rafinutshaw
commented
Apr 29, 2024
Comment on lines
108
to
116
| it("should create an empty cell with styling", () => { | ||
| const b2 = sheet.getCellInfoAt(1, 1)!; | ||
| sheet.setCellStyle( | ||
| b2.position!.columnKey!, | ||
| b2.position!.rowKey!, | ||
| new CellStyle(new Map([["width", "50px"]])), | ||
| ); | ||
| sheet.setCellCss(1, 1, new Map<string, string>([["width", "50px;"]])); | ||
|
|
||
| sheet.setCellAt(1, 1, ""); | ||
|
|
||
| // Clearing the style should result in the cell being deleted. | ||
| sheet.setCellStyle(b2!.position.columnKey!, b2!.position.rowKey!, null); | ||
| sheet.setCellCss(1, 1, new Map<string, string>()); | ||
| expect(sheet.getCellInfoAt(1, 1)).toBeNull(); | ||
| }); |
There was a problem hiding this comment.
This test is failing. maybe I did something wrong something. I am a bit tired as well, It would be nice if someone can get me insights on why this maybe happening.
There was a problem hiding this comment.
deleteCellIfUnused only checks for the existence of a style. SetCellCss calls CellStyle::clearCss, but never cleans up empty CellStyle objects assigned to cells. I'd suggest using the existing clearCellStyle method, maybe along with a method similar to deleteCellIfUnused that checks if a cell-specific style is still relevant after a change. The code should make sure that no unused or irrelevant (i.e., empty or not differing from group/sheet default style) styling objects are stored.
Fluglow
reviewed
Apr 29, 2024
Comment on lines
+18
to
+22
| export enum GroupTypes { | ||
| Column = 1, | ||
| Row, | ||
| } | ||
| export type GroupType = GroupTypes; |
# Conflicts: # src/core/evaluation/expressionHandler.ts # src/main.ts # src/utils/helpers.ts # src/view/view.ts # tests/core/structure/cellStyle.test.ts # tests/core/structure/formatter.test.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main features
Additional work
Didnt do