Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement feature request: add litecoin support (issue #142) #149

Closed
wants to merge 7 commits into from
Closed

Implement feature request: add litecoin support (issue #142) #149

wants to merge 7 commits into from

Conversation

ghost
Copy link

@ghost ghost commented May 8, 2019

Please could you review the following proposal for enabling litecoin support in Neutrino. It boils down to having litecoin genesis block details and using the ltcsuite CheckProofOfWork method.

Neutrino/blockmanager.go/CheckHeaderSanity :
if configured for litecoin,
copy the block header into a ltcutil.block and call ltcsuite.ltcd.blockchain.CheckProofOfWork

Neutrino/query.go/GetBlock :
if configured for litecoin,
copy the block into a ltcutil.block and call ltcsuite.ltcd.blockchain.CheckBlockSanity

ref: #142

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 68.715% when pulling ede6a8e on Wowee0:litecoin_hacks into a655679 on lightninglabs:master.

@ghost ghost closed this May 15, 2019
@kilrau
Copy link

kilrau commented Jun 17, 2019

May I ask why this was closed? @Wowee0

@ghost
Copy link
Author

ghost commented Jun 17, 2019

May I ask why this was closed?

Because we were told it would not be accepted, that we should fork Neutrino instead. @kilrau

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants