Trampoline Payload Construction Method #3386
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
reviewed
Oct 29, 2024
| /// amended to match the features present in the invoice this node generated. | ||
| pub node_features: NodeFeatures, | ||
| /// The channel_announcement features of the channel that should be used from the previous hop | ||
| /// to reach this node. |
There was a problem hiding this comment.
I'm really confused, there's no explicit way that I see in OutboundOnionPayload::BlindedForward to specify the channel used. The previous trampoline hop can pick any channel they want, AFAIU...
| @@ -454,6 +454,9 @@ impl_writeable_tlv_based!(BlindedTail, { | |||
| pub struct Path { | |||
| /// The list of unblinded hops in this [`Path`]. Must be at least length one. | |||
| pub hops: Vec<RouteHop>, | |||
| /// The list of unblinded Trampoline hops. If present, must be at least one. | |||
There was a problem hiding this comment.
Vacuous statement is vacuous.
| @@ -454,6 +454,9 @@ impl_writeable_tlv_based!(BlindedTail, { | |||
| pub struct Path { | |||
| /// The list of unblinded hops in this [`Path`]. Must be at least length one. | |||
| pub hops: Vec<RouteHop>, | |||
| /// The list of unblinded Trampoline hops. If present, must be at least one. | |||
| /// The public key of the first Trampoline hop must match the public key of the last regular hop. | |||
There was a problem hiding this comment.
I don't see why this needs to be true. Can we just have each trampoline hop be next hops starting after the last unblinded node.
| @@ -454,6 +454,9 @@ impl_writeable_tlv_based!(BlindedTail, { | |||
| pub struct Path { | |||
| /// The list of unblinded hops in this [`Path`]. Must be at least length one. | |||
| pub hops: Vec<RouteHop>, | |||
| /// The list of unblinded Trampoline hops. If present, must be at least one. | |||
| /// The public key of the first Trampoline hop must match the public key of the last regular hop. | |||
| pub trampoline_hops: Vec<TrampolineHop>, | |||
There was a problem hiding this comment.
Seems weird to add this to the public API in a PR that doesn't use it. Can you go ahead and wire up build_trampoline_onion_payloads to build the valid onion in the same PR?
arik-so
force-pushed
the
arik/trampoline/payload-construction
branch
from
68d2c20
to
7cad33e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a method for constructing Trampoline payloads.
This will allow the non-Trampoline method to be modified to generate a Trampoline onion and finish its own regular payload construction.