Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustfmt: Run on the routing directory (2/3) #3337

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tnull
Copy link
Contributor

@tnull tnull commented Sep 24, 2024

Based on #3336.

This is PR 2/3, just formatting router.rs.

Followups: #3338.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.77%. Comparing base (053281f) to head (947cf72).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3337      +/-   ##
==========================================
+ Coverage   89.62%   89.77%   +0.14%     
==========================================
  Files         126      126              
  Lines      103226   105591    +2365     
  Branches   103226   105591    +2365     
==========================================
+ Hits        92521    94796    +2275     
- Misses       7982     8089     +107     
+ Partials     2723     2706      -17     
Flag Coverage Δ
89.77% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tnull
Copy link
Contributor Author

tnull commented Sep 25, 2024

Rebased on main after #3336 landed.

Copy link
Contributor

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with mutation Ci waorkflow but looks like that the failure is unrelated? https://github.com/lightningdevkit/rust-lightning/actions/runs/11026258813/job/30622498871?pr=3337

otherwise LGMT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants