-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustfmt
: Run on util/*
(1/2)
#3324
rustfmt
: Run on util/*
(1/2)
#3324
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3324 +/- ##
==========================================
- Coverage 89.66% 89.64% -0.02%
==========================================
Files 126 126
Lines 102676 102817 +141
Branches 102676 102817 +141
==========================================
+ Hits 92062 92171 +109
- Misses 7894 7923 +29
- Partials 2720 2723 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good but the last commit, which starts to get into our functional tests which need to be cleaned up to be more readable, allowing them to also be more condensed.
7369776
to
15158e7
Compare
Rebased after #3327 landed and addressed outstanding comments. |
15158e7
to
d68a484
Compare
); | ||
io::Error::new(io::ErrorKind::Other, "Monitor update failed") | ||
})?; | ||
log_error!( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol wtf, why is this aligned with the next line up even though its in the method started by the { on the next line up...
The diff is a bit larger for this one, but AFAICT the changes look mostly reasonable (besides the oddity commented below).
FWIW, I had a look at currently open inflight PRs and the conflicts should be minimal if I'm not overlooking something.
This is PR 1/2, follow-up: #3323.