Sweep Fixes #117
Merged
Sweep Fixes #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnull
reviewed
Aug 21, 2023
TheBlueMatt
force-pushed
the
main
branch
4 times, most recently
from
d48022d
to
dae900d
Compare
When we moved the CLI input reading into a `tokio::select`, we ended up blocking the tokio reactor by reading from stdin in a standard tokio future. Instead, we need to let tokio know that we're running a largely-blocking task.
tnull
reviewed
Aug 23, 2023
tnull
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two minor fixes, one that applies, and one that may not actually impact the normal sample, but is a bug which caused some other code I have to fail.