Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Debug utils (#369)" #391

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Revert "Debug utils (#369)" #391

merged 1 commit into from
Sep 21, 2023

Conversation

tetsuo-cpp
Copy link
Contributor

This reverts commit 465ecdc.

@tetsuo-cpp
Revert "Debug utils (#369)"
92c4482 
This reverts commit 465ecdc.
2over12
2over12 approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@2over12 2over12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm we need to figure out what was causing this however, since we need to be on the new pass manager next release

@2over12 2over12 merged commit 4413bfb into patchable-ir-main Sep 21, 2023
6 checks passed
ekilmer added a commit that referenced this pull request Sep 22, 2023
@ekilmer
Merge branch 'patchable-ir-main' into ekilmer/uid-codeblocks
d27b985 
* patchable-ir-main:
  Revert "Debug utils (#369)" (#391)
  Ian/allow for typehints in spec (#390)
  Use encoded type for constant value mappings (#388)
  Remove challenge testing (#389)
  Debug utils (#369)
  Add `-j` flag to `test-amp-challenge-bins.sh` and update ignore list (#380)
@tetsuo-cpp tetsuo-cpp deleted the alex/revert-debug-utils branch December 8, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2over12 2over12 2over12 approved these changes

@Ninja3047 Ninja3047 Awaiting requested review from Ninja3047

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tetsuo-cpp @2over12