Tight up type checking; eliminate remaining type errors.

pyproject.toml

@@ -87,4 +87,4 @@ ignore = [
 [tool.mypy]
 files = [ "src/**/*.py" ]
 strict = "True"
-warn_return_any = "False"
+pretty = "True"

src/codehelp/class_config.py

@@ -12,7 +12,8 @@
 
 
 def _default_langs() -> list[str]:
-    return current_app.config['DEFAULT_LANGUAGES']
+    langs: list[str] = current_app.config['DEFAULT_LANGUAGES']  # declaration keeps mypy happy
+    return langs
 
 
 @dataclass(frozen=True)

src/gened/auth.py

@@ -176,7 +176,7 @@ def get_auth() -> AuthDict:
     if 'auth' not in g:
         g.auth = _get_auth_from_session()
 
-    return g.auth
+    return g.auth  # type: ignore[no-any-return]
 
 
 def get_last_role(user_id: int) -> int | None:

src/gened/class_config.py

@@ -123,7 +123,7 @@ def get_class_config(config_class: type[T]) -> T:
             class_config_dict = json.loads(config_row['config'])
             g.class_config = config_class(**class_config_dict)
 
-    return g.class_config
+    return g.class_config  # type: ignore [no-any-return]
 
 
 @bp.route("/")

src/gened/classes.py

@@ -59,6 +59,7 @@ class name from the LMS
             db.execute("UPDATE classes SET name=? WHERE id=?", [class_name, class_row['id']])
             db.commit()
 
+        assert isinstance(class_row['id'], int)
         return class_row['id']
 
     else:

src/gened/docs.py

@@ -5,7 +5,7 @@
 from dataclasses import dataclass
 from pathlib import Path
 
-import frontmatter
+import frontmatter  # type: ignore [import-untyped]
 from flask import Blueprint, abort, current_app, render_template
 from markdown_it import MarkdownIt
 

src/gened/lti.py

@@ -14,7 +14,8 @@
     session,
     url_for,
 )
-from pylti.flask import lti
+from pylti.flask import LTI  # type: ignore [import-untyped]
+from pylti.flask import lti as lti_flask
 from werkzeug.wrappers.response import Response
 
 from .auth import (
@@ -39,8 +40,8 @@ def lti_error(exception: dict[str, Any]) -> tuple[str, int]:
 # https://github.com/mitodl/pylti/blob/master/pylti/flask.py
 # https://github.com/mitodl/mit_lti_flask_sample
 @bp.route("/", methods=['GET', 'POST'])
-@lti(request='initial', error=lti_error)
-def lti_login(lti=lti) -> Response | tuple[str, int]:
+@lti_flask(request='initial', error=lti_error)  # type: ignore [misc]
+def lti_login(lti: LTI) -> Response | tuple[str, int]:  # noqa: ARG001 (unused argument required by lti_flask decorator)
     authenticated = session.get("lti_authenticated", False)
     role = session.get("roles", "").lower()
     full_name = session.get("lis_person_name_full", None)
@@ -130,5 +131,5 @@ def lti_config() -> tuple[str, int, dict[str, str]]:
 
 #@bp.route("debug", methods=['GET'])
 #@lti(request='session')
-#def lti_debug(lti=lti):
+#def lti_debug(lti: LTI):
 #    return {var: session[var] for var in session}

src/gened/oauth.py

@@ -2,7 +2,7 @@
 #
 # SPDX-License-Identifier: AGPL-3.0-only
 
-from authlib.integrations.flask_client import OAuth, OAuthError
+from authlib.integrations.flask_client import OAuth, OAuthError  # type: ignore [import-untyped]
 from flask import Blueprint, abort, current_app, redirect, request, session, url_for
 from flask.app import Flask
 from werkzeug.wrappers.response import Response
@@ -65,7 +65,9 @@ def login(provider_name: str) -> Response:
         session[NEXT_URL_SESSION_KEY] = next_url
 
     redirect_uri = url_for('.auth', provider_name=provider_name, _external=True)
-    return client.authorize_redirect(redirect_uri)
+    redir = client.authorize_redirect(redirect_uri)
+    assert isinstance(redir, Response)
+    return redir
 
 
 @bp.route('/auth/<string:provider_name>')