Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPD-45429 Simplify debounce functions to remove react compiler warnings #16824

Closed
wants to merge 2 commits into from
Closed

LPD-45429 Simplify debounce functions to remove react compiler warnings #16824

wants to merge 2 commits into from

Conversation

victorg1991
Copy link
Collaborator

No description provided.

@liferay-page-management
Copy link
Owner

Thank you for submitting this PR. 👏

Make sure it follows the Echo Pull Request Template if you haven't already done so.

Learn more about it here.

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@victorg1991 victorg1991 added the ✋ Waiting for tests Pull requests that cannot be forwarded because tests are passing label Jan 8, 2025
@victorg1991
Copy link
Collaborator Author

ci:test:page-management-playwright

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:page-management-playwright - 11 out of 11 jobs passed in 1 hour 24 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 61b58512ab7f586f7ca6824d9a013acf90aafc3f

Upstream Comparison:

Branch GIT ID: 83a242f48ab4b2086965005a590a95e42e9c0a13
Jenkins Build URL: EE Development Acceptance (master) - 1117 - 2025-01-04[12:36:18]

ci:test:page-management-playwright - 11 out of 11 jobs PASSED
11 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@ealonso
Copy link
Collaborator

ealonso commented Jan 8, 2025

ci:forward

@ealonso ealonso added ✅ Ready to Merge Pull request is ready and can be forwarded. and removed ✋ Waiting for tests Pull requests that cannot be forwarded because tests are passing labels Jan 8, 2025
@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

The pull request will automatically be forwarded to the user brianchandotcom If the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 61b58512ab7f586f7ca6824d9a013acf90aafc3f

Sender Branch:

Branch Name: LPD-45429_fragment_Web
Branch GIT ID: 3653530753e0677a944589c67a90703a493c780f

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:stable - 23 out of 24 jobs passed

❌ ci:test:relevant - 28 out of 30 jobs passed in 1 hour 34 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 61b58512ab7f586f7ca6824d9a013acf90aafc3f

Upstream Comparison:

Branch GIT ID: 83a242f48ab4b2086965005a590a95e42e9c0a13
Jenkins Build URL: EE Development Acceptance (master) - 1117 - 2025-01-04[12:36:18]

ci:test:stable - 23 out of 24 jobs PASSED

1 Failed Jobs:

23 Successful Jobs:
    ci:test:relevant - 28 out of 30 jobs PASSED

    2 Failed Jobs:

    28 Successful Jobs:
      For more details click here.

      Failures unique to this pull:

      1. js-unit/1/0
        1. .opt.dev.projects.github.liferay-portal.modules.dxp.apps.commerce.commerce-organization-web.test.js.objects.fields.MultiselectPicklist object field in "edit" mode displays a ClayMultiSelect with i18n items with a preselected value if set
          Error: expect(jest.fn()).toHaveBeenCalledWith(...expected)

            

          • Expected
            • 

          

            

          • 

            Received
            

            Object {
            
"hasError": false,
            
"name": "test-picklist",
            

            • 

          

            

          • "value": "key2",
            • 

          

            

          • "value": "",
            
},
            • 

          

          Number of calls: 1
          
at call (/opt/dev/projects/github/liferay-portal/modules/dxp/apps/commerce/commerce-organization-web/test/js/objects/fields/MultiselectPicklist.js:184:21)
          
at tryCatch (/opt/dev/projects/github/liferay-portal/modules/dxp/apps/commerce/commerce-organization-web/test/js/objects/fields/MultiselectPicklist.js:2:1)
          
at Generator._invoke (/opt/dev/projects/github/liferay-portal/modules/dxp/apps/commerce/commerce-organization-web/test/js/objects/fields/MultiselectPicklist.js:2:1)
          
at Generator.next (/opt/dev/projects/github/liferay-portal/modules/dxp/apps/commerce/commerce-organization-web/test/js/objects/fields/MultiselectPicklist.js:2:1)
          
at asyncGeneratorStep (/opt/dev/projects/github/liferay-portal/modules/dxp/apps/commerce/commerce-organization-web/test/js/objects/fields/MultiselectPicklist.js:2:1)
          
at _next (/opt/dev/projects/github/liferay-portal/modules/dxp/apps/commerce/commerce-organization-web/test/js/objects/fields/MultiselectPicklist.js:2:1)

      For upstream results, click here.

      @liferay-continuous-integration
      Copy link
      Collaborator

      @ealonso
      Copy link
      Collaborator

      ealonso commented Jan 8, 2025

      ci:forward

      @liferay-continuous-integration
      Copy link
      Collaborator

      CI is automatically triggering the following test suites:

      •     ci:test:relevant
      •     ci:test:sf
      •     ci:test:stable

      The pull request will automatically be forwarded to the user brianchandotcom If the following test suites pass:

      •     ci:test:relevant
      •     ci:test:sf
      •     ci:test:stable

      @liferay-continuous-integration
      Copy link
      Collaborator

      Skipping previously passed test suites:

      • ci:test:sf

      @liferay-continuous-integration
      Copy link
      Collaborator

      ✔️ ci:test:stable - 24 out of 24 jobs passed

      ✔️ ci:test:relevant - 30 out of 30 jobs passed in 54 minutes

      Click here for more details.

      Base Branch:

      Branch Name: master
      Branch GIT ID: 61b58512ab7f586f7ca6824d9a013acf90aafc3f

      Upstream Comparison:

      Branch GIT ID: 83a242f48ab4b2086965005a590a95e42e9c0a13
      Jenkins Build URL: EE Development Acceptance (master) - 1117 - 2025-01-04[12:36:18]

      ci:test:stable - 24 out of 24 jobs PASSED
      24 Successful Jobs:
      ci:test:relevant - 30 out of 30 jobs PASSED
      30 Successful Jobs:
      For more details click here.

      @liferay-continuous-integration
      Copy link
      Collaborator

      All required test suite(s) passed.
      Forwarding pull request to brianchandotcom.
      Console

      @liferay-continuous-integration liferay-continuous-integration mentioned this pull request Jan 8, 2025
      Closed
      @liferay-continuous-integration
      Copy link
      Collaborator

      Pull request has been successfully forwarded to brianchandotcom#157563
      Console

      @liferay-continuous-integration
      Copy link
      Collaborator

      @victorg1991 victorg1991 deleted the LPD-45429_fragment_Web branch January 20, 2025 22:32
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Reviewers

      @liferay-page-management liferay-page-management Awaiting requested review from liferay-page-management liferay-page-management is a code owner

      Assignees
      No one assigned
      Labels
      ci:test:page-management-playwright - success ci:test:relevant - success ci:test:sf - success ci:test:stable - success ✅ Ready to Merge Pull request is ready and can be forwarded.
      Projects
      None yet
      Milestone
      No milestone
      Development

      Successfully merging this pull request may close these issues.
      4 participants
      @victorg1991 @liferay-page-management @liferay-continuous-integration @ealonso