Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update playwright tests #5826

Closed

Conversation

victorg1991
Copy link

@victorg1991 victorg1991 commented Jan 22, 2025

Hey guys!

Recently we have changed the page administration interface and some test may not be working. I have updated a bunch of your test to showcase the changes needed for it to work in order to help a bit 😄 Let me know what do you think

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

Copy link
Collaborator

@alessiorendina alessiorendina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me. If tests pass, we can forward it. Thank you, @victorg1991

@victorg1991
Copy link
Author

ci:test:commerce

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:commerce - 88 out of 216 jobs passed in 2 hours 34 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 95dc7cfc1d6b1c46b9ad94437f35056cada98839

Upstream Comparison:

Branch GIT ID: 95dc7cfc1d6b1c46b9ad94437f35056cada98839
Jenkins Build URL: EE Development Acceptance (master) - 1154 - 2025-01-28[21:20:07]

ci:test:commerce - 88 out of 216 jobs PASSED

128 Failed Jobs:

88 Successful Jobs:
    For more details click here.

    Failures unique to this pull:

    1. ...

    @liferay-continuous-integration
    Copy link
    Collaborator

    Jenkins Report:jenkins-report.html
    Jenkins Suite:commerce
    Testray Routine:EE Pull Request
    Testray Build ID:<code>122351834</code>

    @victorg1991
    Copy link
    Author

    ci:test:playwright

    @liferay-continuous-integration
    Copy link
    Collaborator

    ❌ ci:test:playwright - 87 out of 121 jobs passed in 1 hour 51 minutes

    Click here for more details.

    Base Branch:

    Branch Name: master
    Branch GIT ID: 729163741639c6f6875c5ad7633a318a69a57f6e

    Upstream Comparison:

    Branch GIT ID: 729163741639c6f6875c5ad7633a318a69a57f6e
    Jenkins Build URL: EE Development Acceptance (master) - 1155 - 2025-01-29[12:37:10]

    ci:test:playwright - 87 out of 121 jobs PASSED

    34 Failed Jobs:

    87 Successful Jobs:
      For more details click here.

      Failures unique to this pull:

      @liferay-continuous-integration
      Copy link
      Collaborator

      Jenkins Report:jenkins-report.html
      Jenkins Suite:playwright
      Testray Routine:EE Pull Request
      Testray Build ID:<code>123204084</code>

      @victorg1991
      Copy link
      Author

      ci:forward

      @liferay-continuous-integration
      Copy link
      Collaborator

      CI is automatically triggering the following test suites:

      •     ci:test:relevant
      •     ci:test:sf
      •     ci:test:stable

      The pull request will automatically be forwarded to the user brianchandotcom If the following test suites pass:

      •     ci:test:relevant
      •     ci:test:sf
      •     ci:test:stable

      @liferay-continuous-integration
      Copy link
      Collaborator

      ❌ ci:test:sf - 0 out of 1 jobs passed in 5 minutes

      Click here for more details.

      Base Branch:

      Branch Name: master
      Branch GIT ID: c15e61abf4c6ae654f6ebf9161b1d39f0caa1fe8

      Sender Branch:

      Branch Name: LPD-46951_commerce
      Branch GIT ID: 6604915eef61b28ba567927704da65b0e4e98ece

      0 out of 1jobs PASSED
      For more details click here.
           [exec] > Task :packageRunCheckFormat
           [exec] yarn run v1.13.0
           [exec] \$ node-scripts check:ci
           [exec] 
           [exec] ?????? Running preflight checks...
           [exec]    ?? BAD - node-scripts sha256 field is not up-to-date: run yarn format at modules/_node-scripts
           [exec] 
           [exec] ?????? Checking outdated tsconfig.json files ...
           [exec] 
           [exec] ?????? Running TypeScript checks on modified files...
           [exec] ?????? A total of 8 CPUs were detected: launching tsc using 8 workers
           [exec] 
           [exec] ?????? Running format checks on modified files...
           [exec] ??? CI checks failed.
           [exec] error Command failed with exit code 1.
           [exec] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
           [exec] 
           [exec] > Task :packageRunCheckFormat FAILED
           [exec] Gradle build finished at 2025-01-30 13:36:15.241.
           [exec] 
           [exec] 
           [exec] FAILURE: Build failed with an exception.
           [exec] 
           [exec] * What went wrong:
           [exec] Execution failed for task ':packageRunCheckFormat'.
           [exec] > Process 'command '/opt/dev/projects/github/liferay-portal/build/node/bin/node'' finished with non-zero exit value 1
           [exec] 
           [exec] * Try:
           [exec] > Run with --info or --debug option to get more log output.
           [exec] > Run with --scan to get full insights.
           [exec] > Get more help at https://help.gradle.org.
           [exec] 
           [exec] * Exception is:
           [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':packageRunCheckFormat'.
           [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda\$executeIfValid\$1(ExecuteActionsTaskExecuter.java:148)
           [exec]   at org.gradle.internal.Try\$Failure.ifSuccessfulOrElse(Try.java:282)
           [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:146)
           [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:134)
           [exec]   at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
           [exec]   at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:51)
           [exec]   at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)

      @liferay-continuous-integration
      Copy link
      Collaborator

      ❌ ci:test:relevant - 0 out of 1 jobs passed in 3 minutes

      Click here for more details.

      Base Branch:

      Branch Name: master
      Branch GIT ID: c15e61abf4c6ae654f6ebf9161b1d39f0caa1fe8

      Upstream Comparison:

      Branch GIT ID: 729163741639c6f6875c5ad7633a318a69a57f6e
      Jenkins Build URL: EE Development Acceptance (master) - 1155 - 2025-01-29[12:37:10]

      ci:test:relevant - 0 out of 1 jobs PASSED
      For more details click here.

      Failures unique to this pull:

      1. test-portal-acceptance-pullrequest(master)
        Job Results:

        0 Jobs Passed.
        1 Job Failed.

        A CI failure has occurred. CI Infrastructure has been notified. Please try again later or contact CI Infrastructure for an update.

      For upstream results, click here.

      @liferay-continuous-integration
      Copy link
      Collaborator

      Jenkins Report:jenkins-report.html
      Jenkins Suite:sf
      Testray Routine:EE Pull Request
      Testray Build ID:<code>123306927</code>

      @liferay-continuous-integration
      Copy link
      Collaborator

      Jenkins Report:jenkins-report.html
      Jenkins Suite:relevant
      Testray Routine:EE Pull Request
      Testray Build ID:<code>123314236</code>

      @victorg1991
      Copy link
      Author

      ci:forward

      @liferay-continuous-integration
      Copy link
      Collaborator

      CI is automatically triggering the following test suites:

      •     ci:test:relevant
      •     ci:test:sf
      •     ci:test:stable

      The pull request will automatically be forwarded to the user brianchandotcom If the following test suites pass:

      •     ci:test:relevant
      •     ci:test:sf
      •     ci:test:stable

      @liferay-continuous-integration
      Copy link
      Collaborator

      Build completed.

      Jenkins URL: test-portal-acceptance-pullrequest(master)

      The relevant test suite did not execute tests because all modified files were excluded by the modified.files.global.excludes property in test.properties.

      Please use ci:test:sf and/or ci:forward for this pull request to be forwarded or eligible for forwarding.

      @liferay-continuous-integration
      Copy link
      Collaborator

      Jenkins Report:jenkins-report.html
      Jenkins Suite:relevant
      Testray Routine:EE Pull Request
      Testray Build ID:<code>123318168</code>

      @liferay-continuous-integration
      Copy link
      Collaborator

      ❌ ci:test:sf - 0 out of 1 jobs passed in 5 minutes

      Click here for more details.

      Base Branch:

      Branch Name: master
      Branch GIT ID: c15e61abf4c6ae654f6ebf9161b1d39f0caa1fe8

      Sender Branch:

      Branch Name: LPD-46951_commerce
      Branch GIT ID: 6604915eef61b28ba567927704da65b0e4e98ece

      0 out of 1jobs PASSED
      For more details click here.
           [exec] > Task :packageRunCheckFormat
           [exec] yarn run v1.13.0
           [exec] \$ node-scripts check:ci
           [exec] 
           [exec] ⚙️ Running preflight checks...
           [exec]    · BAD - node-scripts sha256 field is not up-to-date: run yarn format at modules/_node-scripts
           [exec] 
           [exec] ⚙️ Checking outdated tsconfig.json files ...
           [exec] 
           [exec] ⚙️ Running TypeScript checks on modified files...
           [exec] ℹ️ A total of 12 CPUs were detected: launching tsc using 12 workers
           [exec] 
           [exec] ⚙️ Running format checks on modified files...
           [exec] ❌ CI checks failed.
           [exec] error Command failed with exit code 1.
           [exec] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
           [exec] 
           [exec] > Task :packageRunCheckFormat FAILED
           [exec] Gradle build finished at 2025-01-30 13:53:01.131.
           [exec] 
           [exec] 
           [exec] FAILURE: Build failed with an exception.
           [exec] 
           [exec] * What went wrong:
           [exec] Execution failed for task ':packageRunCheckFormat'.
           [exec] > Process 'command '/opt/dev/projects/github/liferay-portal/build/node/bin/node'' finished with non-zero exit value 1
           [exec] 
           [exec] * Try:
           [exec] > Run with --info or --debug option to get more log output.
           [exec] > Run with --scan to get full insights.
           [exec] > Get more help at https://help.gradle.org.
           [exec] 
           [exec] * Exception is:
           [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':packageRunCheckFormat'.
           [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda\$executeIfValid\$1(ExecuteActionsTaskExecuter.java:148)
           [exec]   at org.gradle.internal.Try\$Failure.ifSuccessfulOrElse(Try.java:282)
           [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:146)
           [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:134)
           [exec]   at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
           [exec]   at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:51)
           [exec]   at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)

      @liferay-continuous-integration
      Copy link
      Collaborator

      Jenkins Report:jenkins-report.html
      Jenkins Suite:sf
      Testray Routine:EE Pull Request
      Testray Build ID:<code>123318254</code>

      @victorg1991
      Copy link
      Author

      ci:test:sf

      @liferay-continuous-integration
      Copy link
      Collaborator

      ❌ ci:test:sf - 0 out of 1 jobs passed in 4 minutes

      Click here for more details.

      Base Branch:

      Branch Name: master
      Branch GIT ID: c15e61abf4c6ae654f6ebf9161b1d39f0caa1fe8

      Sender Branch:

      Branch Name: LPD-46951_commerce
      Branch GIT ID: 6604915eef61b28ba567927704da65b0e4e98ece

      0 out of 1jobs PASSED
      For more details click here.
           [exec] > Task :packageRunCheckFormat
           [exec] yarn run v1.13.0
           [exec] \$ node-scripts check:ci
           [exec] 
           [exec] ⚙️ Running preflight checks...
           [exec] 
           [exec]    · BAD - node-scripts sha256 field is not up-to-date: run yarn format at modules/_node-scripts
           [exec] ⚙️ Checking outdated tsconfig.json files ...
           [exec] 
           [exec] ⚙️ Running TypeScript checks on modified files...
           [exec] ℹ️ A total of 12 CPUs were detected: launching tsc using 12 workers
           [exec] 
           [exec] ⚙️ Running format checks on modified files...
           [exec] ❌ CI checks failed.
           [exec] error Command failed with exit code 1.
           [exec] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
           [exec] 
           [exec] > Task :packageRunCheckFormat FAILED
           [exec] 
           [exec] 
           [exec] FAILURE: Build failed with an exception.
           [exec] 
           [exec] * What went wrong:
           [exec] Execution failed for task ':packageRunCheckFormat'.
           [exec] > Process 'command '/opt/dev/projects/github/liferay-portal/build/node/bin/node'' finished with non-zero exit value 1
           [exec] 
           [exec] * Try:
           [exec] > Run with --info or --debug option to get more log output.
           [exec] > Run with --scan to get full insights.
           [exec] > Get more help at https://help.gradle.org.
           [exec] 
           [exec] * Exception is:
           [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':packageRunCheckFormat'.
           [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda\$executeIfValid\$1(ExecuteActionsTaskExecuter.java:148)
           [exec]   at org.gradle.internal.Try\$Failure.ifSuccessfulOrElse(Try.java:282)
           [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:146)
           [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:134)
           [exec]   at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
           [exec]   at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:51)
           [exec]   at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)

      @liferay-continuous-integration
      Copy link
      Collaborator

      Jenkins Report:jenkins-report.html
      Jenkins Suite:sf
      Testray Routine:EE Pull Request
      Testray Build ID:<code>124111452</code>

      @victorg1991 victorg1991 closed this Feb 3, 2025
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Projects
      None yet
      Development

      Successfully merging this pull request may close these issues.

      3 participants