Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: how to exclude packages #21

Merged
merged 1 commit into from
Apr 10, 2024
Merged

doc: how to exclude packages #21

merged 1 commit into from
Apr 10, 2024

Conversation

shawnzhu
Copy link
Member

looking forward a change to support esbuild argument --external via blamda CLI

@shawnzhu shawnzhu added the documentation Improvements or additions to documentation label Apr 10, 2024
@shawnzhu shawnzhu requested review from jagoda and swain April 10, 2024 15:48
@jagoda
Copy link

jagoda commented Apr 10, 2024

It looks like the bundle() function accepts ESBuild options. See https://github.com/lifeomic/blamda/blob/master/src/bundle.ts#L44 A more convenient "fix" would be to support supplying custom ESBuild options on the command line and pass them through.

esbuild: {
minify: true,
sourcemap: 'inline',
external: ['dtrace-provider'], // exclude dtrace-provider
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite a common package -- should we just build-in an exclusion to the bundle command?

Copy link
Member Author

@shawnzhu shawnzhu Apr 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes for users who usually run bundled code on linux :)

@shawnzhu shawnzhu merged commit b2c4d8f into master Apr 10, 2024
4 checks passed
@shawnzhu shawnzhu deleted the doc branch April 10, 2024 16:15
Copy link

🎉 This PR is included in version 1.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Has been released to the package repository (NPM, etc) label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation released Has been released to the package repository (NPM, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants