Support for MP3 files < MAX_FRAME_SYNC_MATCHES #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misyltoad
added a commit
to misyltoad/VAudio-MiniMP3
that referenced
this pull request
Aug 9, 2024
If we match > 1 frame, and the next frame header is all NULL or a TAG then say that we matched a frame, as we likely reached the end of the file. lieff/minimp3#125
|
This makes the tests fail: I have not looked into why that is. |
If we match > 1 frame, and the next frame header is all NULL or a TAG then say that we matched a frame, as we likely reached the end of the file. Fixes: lieff#102
manxorist
added a commit
to OpenMPT/openmpt
that referenced
this pull request
Aug 15, 2024
…eleases/tag/openmpt-2024-08-15-v3> commit 2811a29e4115199209fe91ae5217c9c5fc611fa6 (2024-08-15). This applies the following pull requests: <lieff/minimp3#125>. git-svn-id: https://source.openmpt.org/svn/openmpt/trunk/OpenMPT@21446 56274372-70c3-4bfc-bfc3-4c3a0b034d27
manxorist
added a commit
to OpenMPT/openmpt
that referenced
this pull request
Aug 15, 2024
[Var] minimp3: Update to fork <https://github.com/manxorist/minimp3/releases/tag/openmpt-2024-08-15-v3> commit 2811a29e4115199209fe91ae5217c9c5fc611fa6 (2024-08-15). This applies the following pull requests: <lieff/minimp3#125>. ........ git-svn-id: https://source.openmpt.org/svn/openmpt/branches/OpenMPT-1.31@21447 56274372-70c3-4bfc-bfc3-4c3a0b034d27
|
curious as to if it is fixed on what I just pushed today? i had a typo |
Yes, the tests pass now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we match > 1 frame, and the next frame header is all NULL or a TAG then say that we matched a frame, as we likely reached the end of the file.
Fixes: #102