Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated ether validators #186

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

Tarens2
Copy link
Contributor

@Tarens2 Tarens2 commented Feb 9, 2024

No description provided.

@Tarens2 Tarens2 requested a review from a team as a code owner February 9, 2024 12:13
Copy link

linear bot commented Feb 9, 2024

SI-1214 [Buffer] Fixes after tests

  • пару раз при запросе на GET /v2/request-time?ids=... с 20 элементами, выполнение запроса занимало более 10 секунд (скрин 1)

  • запрос на GET /v2/request-time/calculate с значением amount=12345678901234 выдает 500ую (скрин 2)

  • есть вопрос на счет валидации значений меньше 0. Сейчас выдается 400ая с текстом Amount is too small. Понимаю, что на фронте тоже 100% будет валидация, чтоб значение не было отрицательным, но мб стоит обработать и выдавать подходящую текстовку типо Amount must not be less than 0

original message: https://discord.com/channels/761182643269795850/1159062178196897884/1201798323321962548

@Tarens2 Tarens2 merged commit 6119d4b into develop Feb 9, 2024
4 checks passed
@Tarens2 Tarens2 deleted the feature/si-1214-buffer-fixes-after-tests branch February 9, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants