Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport: changes from master to develop #229

Merged
merged 46 commits into from
Oct 10, 2024
Merged

backport: changes from master to develop #229

merged 46 commits into from
Oct 10, 2024

Conversation

tamtamchik
Copy link
Member

@tamtamchik tamtamchik commented Oct 9, 2024 •
edited
Loading

Want to prepare the develop branch to be ported to lido-dao.

tamtamchik and others added 30 commits September 23, 2024 13:42
@tamtamchik
build: update node dependencies
e125ff9
@tamtamchik
build: update poetry dependencies
4eed5ed
@tamtamchik
docs: update contributions guide
caf4241
@tamtamchik
docs: improve test running section
ebc8d28
@tamtamchik
docs: some word juggling
42677fa
@tamtamchik
chore: test naming
0426b00
@tamtamchik
chore: fix some typos
f0ad8ee
@tamtamchik
chore: update scratch deploy
555d42f
@tamtamchik @TheDZhon
fix: apply suggestions from code review
26d5e96 
Co-authored-by: Eugene Mamin <[email protected]>
@tamtamchik
fix: apply review suggestions
e20a363
@tamtamchik
Merge pull request #213 from lidofinance/feat/ci-integration-workflow
1476763
@tamtamchik
Merge pull request #215 from lidofinance/feat/master-mirror
dcaec48 
chore: sync repovation with master
@tamtamchik
ci: try to use lidofinance/hardhat-node
47f4ab2
@tamtamchik
ci: use lidofinance/hardhat-node for scratch
e3feffd
@tamtamchik
chore: updates from the lido-dao main branch
3902bd2
@tamtamchik
Merge pull request #217 from lidofinance/feat/lido-hardhat
f8e3c67 
ci: use lidofinance/hardhat-node as a base node for CI actions
@tamtamchik
docs: improve texts
e4a6ae4
@tamtamchik
Merge pull request #218 from lidofinance/feat/sync-lido-dao
55164f8 
chore: updates from the lido-dao main branch
@tamtamchik
chore: upgrade hardhat
6e1df1b
@tamtamchik
Merge pull request #219 from lidofinance/feat/hh-speed-up
ff6a009 
chore: update Hardhat to 2.22.12
@tamtamchik
chore: add contract verification script
168c959
@tamtamchik
chore: small refactoring
c808cd3
@tamtamchik
chore: move abi publish to the task
ae1cf46
@tamtamchik
chore: small fix
9da77fe
@tamtamchik
chore: add force compilation before abi extraction
ece84fd
@tamtamchik
ci: remove duplicate compile
0a96d3d
@tamtamchik
chore: simplify tasks definition
cc18828
@nnsW3
Update scratch-deploy.md
c2dcee1
@nnsW3
Update README.md
3094e63
@tamtamchik
Merge pull request #222 from nnsW3/docs-fix-spelling-issues
9eb1257 
Docs fix spelling issues
tamtamchik and others added 14 commits September 30, 2024 11:54
@tamtamchik
Merge branch 'master' into feat/sync-master
93b0c3f 
# Conflicts:
#	docs/scratch-deploy.md
@tamtamchik
Merge pull request #223 from lidofinance/feat/sync-master
25f9583 
chore: sync master
@TheDZhon
Merge pull request #214 from lidofinance/repovation
9fb4503 
chore: repovation update
@tamtamchik
ci: fix
5f32255
@tamtamchik
fix: review
5243b29
@tamtamchik
chore: simplify contract verification
9479c3f
@tamtamchik @TheDZhon
Update globals.d.ts
7484eea 
Co-authored-by: Eugene Mamin <[email protected]>
@tamtamchik
Merge pull request #220 from lidofinance/feat/verify-contracts
87d7f33 
feat: add hardhat task to verify deployed contracts
@tamtamchik
ci: try write all permissions
5bec2ea
@tamtamchik
ci: update permissions once more
f175c55
@tamtamchik
Merge branch 'repovation' into feat/test
4214694
@tamtamchik
Merge pull request #224 from lidofinance/feat/test
5365a63 
chore: testing CI
@tamtamchik
Merge pull request #225 from lidofinance/repovation
aada422 
chore: repovation update
@tamtamchik
Merge branch 'master' into feat/develop-sync
e838b5f
@tamtamchik tamtamchik requested a review from a team as a code owner October 9, 2024 15:28
@tamtamchik tamtamchik changed the base branch from master to develop October 9, 2024 15:28
@tamtamchik tamtamchik requested a review from a team as a code owner October 9, 2024 15:28
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024 •
edited
Loading

badge

Hardhat Unit Tests Coverage Summary

Filename                                                       Stmts    Miss  Cover    Missing
-----------------------------------------------------------  -------  ------  -------  ---------
contracts/0.4.24/Lido.sol                                        212       0  100.00%
contracts/0.4.24/StETH.sol                                        72       0  100.00%
contracts/0.4.24/StETHPermit.sol                                  15       0  100.00%
contracts/0.4.24/lib/Packed64x4.sol                                5       0  100.00%
contracts/0.4.24/lib/SigningKeys.sol                              36       0  100.00%
contracts/0.4.24/lib/StakeLimitUtils.sol                          37       0  100.00%
contracts/0.4.24/nos/NodeOperatorsRegistry.sol                   485       0  100.00%
contracts/0.4.24/oracle/LegacyOracle.sol                          72       0  100.00%
contracts/0.4.24/utils/Pausable.sol                                9       0  100.00%
contracts/0.4.24/utils/Versioned.sol                               5       0  100.00%
contracts/0.6.12/WstETH.sol                                       17       0  100.00%
contracts/0.8.4/WithdrawalsManagerProxy.sol                       61       0  100.00%
contracts/0.8.9/BeaconChainDepositor.sol                          21       2  90.48%   48, 51
contracts/0.8.9/Burner.sol                                        71       0  100.00%
contracts/0.8.9/DepositSecurityModule.sol                        104       0  100.00%
contracts/0.8.9/EIP712StETH.sol                                   16       0  100.00%
contracts/0.8.9/LidoExecutionLayerRewardsVault.sol                16       0  100.00%
contracts/0.8.9/LidoLocator.sol                                   18       0  100.00%
contracts/0.8.9/OracleDaemonConfig.sol                            28       0  100.00%
contracts/0.8.9/StakingRouter.sol                                303       0  100.00%
contracts/0.8.9/WithdrawalQueue.sol                               88       0  100.00%
contracts/0.8.9/WithdrawalQueueBase.sol                          146       0  100.00%
contracts/0.8.9/WithdrawalQueueERC721.sol                         89       0  100.00%
contracts/0.8.9/WithdrawalVault.sol                               21       0  100.00%
contracts/0.8.9/lib/Math.sol                                       4       0  100.00%
contracts/0.8.9/lib/PositiveTokenRebaseLimiter.sol                22       0  100.00%
contracts/0.8.9/lib/SafeCastExt.sol                                3       1  66.67%   26
contracts/0.8.9/lib/UnstructuredRefStorage.sol                     2       0  100.00%
contracts/0.8.9/oracle/AccountingOracle.sol                      171       1  99.42%   723
contracts/0.8.9/oracle/BaseOracle.sol                             89       1  98.88%   397
contracts/0.8.9/oracle/HashConsensus.sol                         263       1  99.62%   1005
contracts/0.8.9/oracle/ValidatorsExitBusOracle.sol                91      91  0.00%    96-461
contracts/0.8.9/proxy/OssifiableProxy.sol                         17       0  100.00%
contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol      225       0  100.00%
contracts/0.8.9/utils/DummyEmptyContract.sol                       0       0  100.00%
contracts/0.8.9/utils/PausableUntil.sol                           31       0  100.00%
contracts/0.8.9/utils/Versioned.sol                               11       0  100.00%
contracts/0.8.9/utils/access/AccessControl.sol                    23       0  100.00%
contracts/0.8.9/utils/access/AccessControlEnumerable.sol           9       0  100.00%
contracts/testnets/sepolia/SepoliaDepositAdapter.sol              21      21  0.00%    49-100
TOTAL                                                           2929     118  95.97%

Diff against master

Filename                                                Stmts    Miss  Cover
----------------------------------------------------  -------  ------  --------
contracts/testnets/sepolia/SepoliaDepositAdapter.sol      +21     +21  +100.00%
TOTAL                                                     +21     +21  -0.69%

Results for commit: 7e0bae9

Minimum allowed coverage is 95%

♻️ This comment has been updated with latest results

TheDZhon
TheDZhon approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@TheDZhon
Copy link
Contributor

image

@TheDZhon TheDZhon merged commit ab36d1c into develop Oct 10, 2024
10 checks passed
@TheDZhon TheDZhon deleted the feat/develop-sync branch October 10, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnmsslido rnmsslido rnmsslido left review comments

@TheDZhon TheDZhon TheDZhon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tamtamchik @TheDZhon @rnmsslido @nnsW3