-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add hardhat task to verify deployed contracts #220
Conversation
tamtamchik
commented
Sep 24, 2024
Hardhat Unit Tests Coverage Summary
Diff against master
Results for commit: cc18828 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested minor improvements
imo having some random bash script in a TS codebase sounds worse than writing a custom hardhat task for verification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am totally ok with the hardhat verification approach given that it's totally automated and strongly typed against the previous bash solution 💪
Left some questions here and there 🙏
4193ac8
to
9479c3f
Compare
Co-authored-by: Eugene Mamin <[email protected]>