Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updates from the lido-dao main branch #218

Merged
merged 2 commits into from
Sep 24, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions contracts/COMPILERS.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,10 @@

For Lido project coordination, governance and funds management we use [Aragon](https://aragon.org/dao), a well-developed and proven DAO Framework. The current stable release of its Kernel, [4.4.0](https://github.com/aragon/aragonOS/tree/v4.4.0) is fixed on the specific compiler version - [solc 0.4.24](https://solidity.readthedocs.io/en/v0.4.24/), that is currently outdated. Keeping security and consistency in mind, we decided to stay on an older yet proven combination - for all the contracts under Aragon management (`Lido`, `stETH`, `LegacyOracle`) we use solc 0.4.24 release.

cstETH token, that acts as autonomous wrapper and not governed by Aragon, was inherited from OpenZeppelin's library, using one of its stable releases [3.1.0](https://github.com/OpenZeppelin/openzeppelin-contracts/releases/tag/v3.1.0).
For the other contracts the newer compiler versions are used.
tamtamchik marked this conversation as resolved.
Show resolved Hide resolved

# How to compile

Separately:

```bash
yarn compile:4
yarn compile:6
```

All at once:

```bash
Expand Down
20 changes: 20 additions & 0 deletions contracts/common/interfaces/IGateSealFactory.sol
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
// SPDX-FileCopyrightText: 2023 Lido <[email protected]>
// SPDX-License-Identifier: GPL-3.0

// See contracts/COMPILERS.md
// solhint-disable-next-line
pragma solidity >=0.4.24 <0.9.0;

// https://github.com/lidofinance/gate-seals/blob/main/contracts/GateSealFactory.vy
interface IGateSealFactory {

event GateSealCreated(address gate_seal);

function create_gate_seal(
address _sealing_committee,
uint256 _seal_duration_seconds,
address[] memory _sealables,
uint256 _expiry_timestamp
) external;

}
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ contract AccountingOracle__MockForLegacyOracle {
}

function submitReportData(AccountingOracle.ReportData calldata data, uint256 /* contractVersion */) external {
require(data.refSlot >= _lastRefSlot, "refSlot less than _lastRefSlot");
uint256 slotsElapsed = data.refSlot - _lastRefSlot;
_lastRefSlot = data.refSlot;

Expand Down
Loading