-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Make a separate, independent java library out of the core
package
#12
base: coreOnly
Are you sure you want to change the base?
Conversation
This allows to hide most of the implementation as package-private
@adolfintel This code will however need some steps from your side in order to make a publication. You will need to make a request to sonatype (the company hosting Maven Central) to allow you to publish the library. Let me know if you need any help with that or if you prefer another method of publishing your library. |
… servers that support both; Updated to latest gradle, android studio, etc; Bumped version to 1.2.3
Hi @adolfintel, In the meanwhile, I have changed the build to upload the artifacts to GitHub's package registry. This is done automatically for any release (on the Here is an example: https://github.com/pec0ra/speedtest-android/packages/2028007 implementation 'com.fdossena:librespeed:1.2.5' |
@pec0ra Yes, I'm still interested and it looks good. I don't have time to work on anything right now, let me know when it's finished and I'll give it a try. |
No problem, I will see if I can make some more improvements. At least the ones in the todo list of the PR description. There is however another point I wanted to bring back again. It is the one of the location of the code. This PR would put the code in a separate A separate repository would have the following benefits:
Let me know what you think. |
I agree, it would be more useful as a java client library that's also compatible with android. |
Hi @adolfintel I improved the README and had another look at the javadoc and things look ready. I kept the code very similar to what already exists (and works) in the master branch of this repo. I tried to only refactor the structure to make it independent from the Android code. Improvements to the library/code can always be made in the future. The User Agent is the only thing that is different from the master branch. I'd like to make it configurable (with a good default) instead of hardcoded but I couldn't find a good way to do it without some code refactoring. I recommend that we keep it as a future improvement. If you setup a new repo, I will reopen this Pull Request against it. |
This PR fixes issue #10
The following has been done:
core
package to itThe following still needs to be done:
Add READMEImprove READMEAdd javadocImprove javadoc