Merge pull request #454 from librariesio/fixing-line-endings

Rubygems parser Gemfile.lock chomp nonprinting newline chars

lib/bibliothecary/parsers/rubygems.rb

@@ -29,7 +29,7 @@ def self.mapping
       end
 
       def self.parse_gemfile_lock(manifest)
-        manifest.split("\n").map do |line|
+        manifest.lines(chomp: true).map do |line|
           match = line.match(NAME_VERSION_4)
           next unless match
           name = match[1]

lib/bibliothecary/version.rb

@@ -1,3 +1,3 @@
 module Bibliothecary
-  VERSION = "6.7.0"
+  VERSION = "6.7.1"
 end

spec/fixtures/GemfileLineEndings.lock

@@ -0,0 +1,4 @@
+GEM
+  remote: https://rubygems.org/
+  specs:
+    rails (5.2.3)

spec/parsers/rubygems_spec.rb

@@ -75,6 +75,24 @@
     })
   end
 
+  it 'parses dependencies from Gemfile.lock with windows line endings' do
+    fixture = load_fixture("GemfileLineEndings.lock")
+    # If this fails, the line endings changed, on this file.
+    # to fix it, run `vim spec/fixtures/GemfileLineEndings.lock +"set ff=dos" +wq`
+    expect(fixture).to include("\r\n")
+
+    expect(
+      described_class.analyse_contents("Gemfile.lock", fixture)).to eq({
+        :platform=>"rubygems",
+        :path=>"Gemfile.lock",
+        :dependencies=>[
+          {:name=>"rails", :requirement=>"5.2.3", :type=>"runtime"},
+        ],
+        kind: 'lockfile',
+        success: true
+      })
+  end
+
   it 'matches valid manifest filepaths' do
     expect(described_class.match?('devise.gemspec')).to be_truthy
     expect(described_class.match?('Gemfile')).to be_truthy