yamux: add error codes on stream reset #622
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
force-pushed
the
error-codes-yamux
branch
from
9294950
to
2fc53ec
Compare
|
We cannot send an error code in Data frames because the body of Data frames is subject to flow control. Using the body of the Data frame will require us to wait for resetting a stream when the receive window on the peer is full. We can use the Window Update frame to send the error code in the Length field similar to how a GoAway frame does. This has no issues as it's not subject to flow control. The Length field has no meaning for existing implementations as the stream is Reset on receiving a frame with RST flag set. |
MarcoPolo
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Nice 👍
Let's wait to merge until we have a proper implementation though.
Also before merge:
- @achingbrain to confirm this is backwards compatible with js-libp2p
- @jxs / @MarcoPolo to confirm this is backwards compatible with rust-libp2p
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for #479
As I understand, all the implementations discard the data when receiving a frame with the
RSTflag set.@MarcoPolo @achingbrain can you confirm this for rust-yamux and js-yamux. I think this is what both the implementations are doing.
We send the error code as a 4byte integer following the header. We cannot use the length field like in a goaway frame, because all the implementations look at the length field and read length bytes of data even with the RST flag set.See #622 (comment) for the alternative