fix: increase providers validity to 48 hours #2801
Merged
+14
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Notes & open questions
The kad-dht specs says:
However in our implementation we take a different approach, whereby we run the
cleanUp
method every 2 hours and only if the record expires in 2 hours do we queue it for a reprovide. This effectively results in a 44 hour Provider Record Republish Intervaljs-libp2p/packages/kad-dht/src/reprovider.ts
Lines 150 to 154 in 7c085d1
Should we increase the
REPROVIDE_THRESHOLD
from 2 hours to 24 hours?Change checklist