chore: actually record errors

libp2p · Oct 26, 2024 · 094eb0b · 094eb0b
1 parent 4162f9a
commit 094eb0b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/packages/kad-dht/src/index.ts b/packages/kad-dht/src/index.ts
@@ -104,7 +104,7 @@
  *       peerInfoMapper: removePrivateAddressesMapper,
  *       logPrefix: 'libp2p:dht-amino',
  *       datastorePrefix: '/dht-amino',
- *       metricsPrefix: 'libp2p_dht_amino
+ *       metricsPrefix: 'libp2p_dht_amino'
  *     })
  *   }
  * })

diff --git a/packages/kad-dht/src/utils.ts b/packages/kad-dht/src/utils.ts
@@ -247,15 +247,15 @@ export function timeOperationGenerator (fn: (...args: any[]) => AsyncGenerator<a
 
       yield * fn(...args)
     } catch (err) {
-      errored = false
+      errored = true
+      stopErrorTimer?.()
+      operationMetrics.errors?.increment({ [type]: true })
+
       throw err
     } finally {
       operationMetrics.queries?.decrement({ [type]: true })
 
-      if (errored) {
-        stopErrorTimer?.()
-        operationMetrics.errors?.increment({ [type]: true })
-      } else {
+      if (!errored) {
         stopSuccessTimer?.()
       }
     }
@@ -273,15 +273,15 @@ export function timeOperationMethod (fn: (...args: any[]) => Promise<any>, opera
 
       return await fn(...args)
     } catch (err) {
-      errored = false
+      errored = true
+      stopErrorTimer?.()
+      operationMetrics.errors?.increment({ [type]: true })
+
       throw err
     } finally {
       operationMetrics.queries?.decrement({ [type]: true })
 
-      if (errored) {
-        stopErrorTimer?.()
-        operationMetrics.errors?.increment({ [type]: true })
-      } else {
+      if (!errored) {
         stopSuccessTimer?.()
       }
     }