Add hsanjuan to Admin / w3dt-stewards

[hsanjuan]

• I am not new and more involved in libp2p stuff than some current admins
• Maintainer of some repos
• To reduce friction, I need the liberty to be able to contribute across the board, request reviews, push branches. I shouldn't be fighting permission issues.
• I used to be able to do this anyways.

[github-actions]

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

libp2p

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # github_team_membership.this["w3dt-stewards:hsanjuan"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = "4657013"
      + username = "hsanjuan"
    }

Plan: 1 to add, 0 to change, 0 to destroy.

[lidel]

I merged #33 to unblock @hsanjuan but he is already Admin in https://github.com/ipfs/github-mgmt/blob/master/github/ipfs.yml so makes sense to do the same here.

Q: @galargh is there a long term plan to remove people from admin group?

[galargh]

Could you remove yourself from members.member list? It's here:

github-mgmt/github/libp2p.yml

Line 66 in 0ebc419

- hsanjuan

Apparently, the setup is perfectly happy about there being duplicate entries between members.admin and members.member but, as you can see in the posted plan, it chose to leave your role in the org as member. At the very least, we should be getting a clearer error about this - I created an issue to track this ipdxco/github-as-code#50.

Q: @galargh is there a long term plan to remove people from admin group?

I'd say that yes, this is the general direction we want to move in. There's no a written plan for it yet though.

@hsanjuan does the fix of repository-team relationship for go-libp2p-relay-daemon resolve the issue you had? Is there anything org-admin permission allows that you found yourself needing lately? I'm trying to understand what setup would work best here.

To reduce friction, I need the liberty to be able to contribute across the board, request reviews, push branches. I shouldn't be fighting permission issues.

These requirements should be satisfied by push access everywhere.

Ideally, I'd like to be able to automatically assign teams to repos on creation. That would help us avoid situations like the one with go-libp2p-relay-daemon.

As for the w3dt-stewards membership, my thinking is that it should reflect the org-chart team membership. So if there's anything this team can do that should be extended to a broader group, I think we might need a new team.

[hsanjuan]

These requirements should be satisfied by push access everywhere

If you promise me that that is going to be the case. The friction comes from that not being the case ie. in relay-daemon.

[hsanjuan]

But yeah, the concrete issue is fixed.

[galargh]

These requirements should be satisfied by push access everywhere

If you promise me that that is going to be the case. The friction comes from that not being the case ie. in relay-daemon.

I think #34 (Automate granting access to all go repos for the Go repos team) is the most important step in ensuring that's the case. We're going to try to prioritise delivering it.

BTW, I have nothing against making you an admin either. I really just wanted to understand the circumstances better so that we can make more informed decision going forward.